Re: pg_trigger.tgparentid
Amit Langote <amitlangote09@gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-02-25T14:57:55Z
Lists: pgsql-hackers
On Tue, Feb 25, 2020 at 11:01 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > On 2020-Feb-25, Amit Langote wrote: > > On Tue, Feb 25, 2020 at 3:58 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > > > Thanks for pointing this out -- I agree it needed rewording. I slightly > > > adjusted your text like this: > > > > > > * Internal triggers require careful examination. Ideally, we don't > > > * clone them. However, if our parent is itself a partition, there > > > * might be internal triggers that must not be skipped; for example, > > > * triggers on our parent that are in turn clones from its parent (our > > > * grandparent) are marked internal, yet they are to be cloned. > > > > > > Is this okay for you? > > > > Thanks. Your revised text looks good, except there is a typo: > > > > in turn clones -> in turn cloned > > Actually, that was on purpose ... (I also changed "were" to "are" to match.) Ah, got it. Thanks, Amit
Commits
-
Record parents of triggers
- b9b408c48724 13.0 landed
-
Fix docs regarding AFTER triggers on partitioned tables
- 902f40dc774b 12.3 landed
- 3acfe6b089a5 13.0 landed
- 143152439dc9 11.8 landed