Re: BUG #16276: Server crash on an invalid attempt to attach a partition to an index

On Tue, Mar 3, 2020 at 2:01 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Mar 02, 2020 at 07:39:44PM +0900, Amit Langote wrote:
> > Done, please see attached.
>
> Thanks.  There are actually some safeguards in ATPrepCmd()@tablecmds.c
> when calling ATSimplePermissions().  However, as this is checked for
> both (ATT_TABLE | ATT_PARTITIONED_INDEX) then it would not blow up as
> ALTER INDEX and ALTER TABLE use the same code path.  Using DETACH
> partition triggers this code path's error though, making the hint
> added in your patch actually correct.
>
> So, applied this stuff down to 11, with test cases on all branches.  I
> have added a test case with ALTER TABLE DETACH PARTITION for an index
> while on it.  As the error is triggered at transformation time which
> is a tad more generic than the work done in tablecmds.c for each
> command, I have also removed the error hint and kept the code
> simpler.

Thank you.  (I totally missed this email.)

- Amit