Re: moving extraUpdatedCols out of RangeTblEntry (into ModifyTable)

Amit Langote <amitlangote09@gmail.com>

From: Amit Langote <amitlangote09@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-01-06T06:45:34Z
Lists: pgsql-hackers
On Fri, Jan 6, 2023 at 3:33 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Langote <amitlangote09@gmail.com> writes:
> > BTW, you wrote in the commit message:
> >     (At present it seems that we don't enforce that for partitioning
> >     either, which is likely wrong to some degree or other; but the case
> >     clearly needs to be handled with traditional inheritance.)
>
> > Maybe I'm missing something, but AFICS, neither
> > traditional-inheritance child tables nor partitions allow a generated
> > column with an expression that is not the same as the parent's
> > expression for the same generated column:
>
> Well, there's some large holes in that, as per my post at [1].
> I'm on board with locking this down for partitioning, but we haven't
> done so yet.
>
> [1] https://www.postgresql.org/message-id/2793383.1672944799%40sss.pgh.pa.us

Ah, I had missed that.  Will check and reply there.

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com



Commits

  1. Fix calculation of which GENERATED columns need to be updated.

  2. Push lpp variable closer to usage in heapgetpage()