Horton

Re: [PATCH] Do not use StdRdOptions in Access Methods

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Nikolay Shaplov <dhyan@nataraj.su>, Dent John <denty@qqdd.eu>, Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "Iwata, Aya" <iwata.aya@jp.fujitsu.com>, Dmitry Dolgov <9erthalion6@gmail.com>
Date: 2019-10-29T04:23:15Z
Lists: pgsql-hackers 
Hi Alvaro,

On Tue, Oct 29, 2019 at 12:02 AM Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> On 2019-Oct-23, Michael Paquier wrote:
> > On Wed, Oct 23, 2019 at 11:16:25AM +0900, Amit Langote wrote:
> > > IMO, parts of the patch that only refactors the existing code should
> > > be first in the list as it is easier to review, especially if it adds
> > > no new concepts.  In this case, your patch to break StdRdOptions into
> > > more manageable chunks would be easier to understand if it built upon
> > > a simplified framework of parsing reloptions text arrays.
> >
> > Thanks for doing a split.  This helps in proving the point that this
> > portion has independent value.
>
> Not a split, yes?  AFAICS this code is nowhere in Nikolay's proposed
> patchset -- it seems completely new development by Amit.  Am I wrong?

IIUC, Nikolay intended to write such a patch but only after getting
some consensus on breaking up StdRdOptions.  I didn't look closely but
an idea similar to the patch I posted (really as a PoC) might have
been discussed couple of years ago, as Nikolay mentioned upthread:

https://commitfest.postgresql.org/15/992/

Thanks,
Amit

Commits

  1. Refactor reloption handling for index AMs in-core

  2. Cleanup code in reloptions.h regarding reloption handling

  3. Refactor code building relation options

  4. Add some assertions to view reloption macros