Re: Eliminating SPI / SQL from some RI triggers - take 3

amit <amitlangote09@gmail.com>

From: Amit Langote <amitlangote09@gmail.com>

To: jie wang <jugierwang@gmail.com>

Cc: Chao Li <li.evan.chao@gmail.com>, Evan Montgomery-Recht <montge@mianetworks.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2026-04-09T09:24:47Z

Lists: pgsql-hackers

On Thu, Apr 9, 2026 at 6:22 PM jie wang <jugierwang@gmail.com> wrote:
>  Hi,
>
> I took a glance at the patch, overall looks good to me. A nitpick on 0001:
>
> +       bool            firing_batch_callbacks; /* true when in
> +                                                                               * FireAfterTriggersBatchCallbacks() */
>
> Looks like a typo in the comment. The function name is FireAfterTriggerBatchCallbacks, no “s” after Trigger.

Thanks, I've fixed the typo in my local tree.

-- 
Thanks, Amit Langote

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix some const qualifier use in ri_triggers.c
- 1b9dc2cb7574 19 (unreleased) landed
doc: Improve consistency of parallel vacuum description.
- 2a3d2f9f68da 19 (unreleased) cited
Move afterTriggerFiringDepth into AfterTriggersData
- d6e96bacd3c0 19 (unreleased) landed
Fix typo left by 34a30786293
- 03029409b409 19 (unreleased) landed
Fix RI fast-path crash under nested C-level SPI
- 34a307862930 19 (unreleased) landed
Add nkeys parameter to recheck_matched_pk_tuple()
- e1cc57fabd6c 19 (unreleased) landed
Fix deferred FK check batching introduced by commit b7b27eb41a5
- 5c54c3ed1b93 19 (unreleased) landed
Optimize fast-path FK checks with batched index probes
- b7b27eb41a5c 19 (unreleased) landed
Make FastPathMeta self-contained by copying FmgrInfo structs
- edee5634564d 19 (unreleased) landed
Add fast path for foreign key constraint checks
- 2da86c1ef9b5 19 (unreleased) landed