Horton

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jeevan Ladhe <jeevanladhe.os@gmail.com>
Date: 2022-06-02T01:23:00Z
Lists: pgsql-hackers 
On Wed, Jun 1, 2022 at 6:15 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Tue, May 31, 2022 at 9:35 PM Robert Haas <robertmhaas@gmail.com> wrote:
> > I would probably just update the synopsis. It's not very hard to
> > figure out what's likely to happen even without clicking through the
> > link, so it seems like it's just being long-winded to duplicate the
> > stuff here. But I don't care much if you feel otherwise.
>
> It looks like there are pros and cons.  I think it’s a matter of
> preference, though.
>
> I thought it would be an improvement, but I agree that we can live
> without it, so I changed my mind; I'll go with my version.  I think we
> could revisit this later.

I guess I'm fine with leaving the text as-is, though slightly bothered
by leaving the phrase "partition of the given parent table with
specified partition bound values" to also cover the DEFAULT partition
case.


--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

Commits

  1. Doc: Further fix CREATE FOREIGN TABLE synopsis.

  2. In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.