Re: pg_trigger.tgparentid

Hi Alvaro,

On Tue, Feb 25, 2020 at 3:58 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> On 2020-Feb-19, Amit Langote wrote:
>
> > Or:
> >
> >          * However, if our parent is a partition itself, there might be
> >          * internal triggers that must not be skipped.  For example, triggers
> >          * on the parent that were in turn cloned from its own parent are
> >          * marked internal, which must be cloned to the partition.
>
> Thanks for pointing this out -- I agree it needed rewording.  I slightly
> adjusted your text like this:
>
>                  * Internal triggers require careful examination.  Ideally, we don't
>                  * clone them.  However, if our parent is itself a partition, there
>                  * might be internal triggers that must not be skipped; for example,
>                  * triggers on our parent that are in turn clones from its parent (our
>                  * grandparent) are marked internal, yet they are to be cloned.
>
> Is this okay for you?

Thanks.  Your revised text looks good, except there is a typo:

in turn clones -> in turn cloned

Thanks,
Amit