Horton

Re: speeding up planning with partitions

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-01-30T17:28:38Z
Lists: pgsql-hackers 
On Wed, Jan 30, 2019 at 3:20 AM David Rowley
<david.rowley@2ndquadrant.com> wrote:
>
> On Tue, 29 Jan 2019 at 22:32, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> >
> > On 2019/01/29 11:23, David Rowley wrote:
> > > 7. In set_inherit_target_rel_sizes() I still don't really like the way
> > > you're adjusting the EquivalenceClasses. Would it not be better to
> > > invent a function similar to adjust_appendrel_attrs(), or just use
> > > that function?
> >
> > OK, I added a function copy_eq_classes_for_child_root() that simply makes
> > a copy of eq_classes from the source root (deep-copying where applicable)
> > and returns the list.
>
> hmm, but you've added a case for SpecialJoinInfo, is there a good
> reason not just to do the translation by just adding an
> EquivalenceClass case to adjust_appendrel_attrs_mutator() then just
> get rid of the new "replace" flag in add_child_rel_equivalences()?
> That way you'd also remove the churn in the couple of places you've
> had to modify the existing calls to add_child_rel_equivalences().

Sounds like something worth trying to make work.  Will do, thanks for the idea.

Thanks,
Amit

Commits

  1. Clean up handling of constraint_exclusion and enable_partition_pruning.

  2. Add test case exercising formerly-unreached code in inheritance_planner.

  3. Speed up planning when partitions can be pruned at plan time.

  4. Avoid crash in partitionwise join planning under GEQO.

  5. Avoid passing query tlist around separately from root->processed_tlist.

  6. Build "other rels" of appendrel baserels in a separate step.

  7. Get rid of duplicate child RTE for a partitioned table.

  8. Rearrange make_partitionedrel_pruneinfo to avoid work when we can't prune.

  9. Don't copy PartitionBoundInfo in set_relation_partition_info.

  10. Move building of child base quals out into a new function

  11. Reorganize planner code moved in b60c39759908

  12. Move inheritance expansion code into its own file

  13. Fix inherited UPDATE/DELETE with UNION ALL subqueries.

  14. Rearrange planner to save the whole PlannerInfo (subroot) for a subquery.