Re: SQL/JSON revisited

Amit Langote <amitlangote09@gmail.com>

From: Amit Langote <amitlangote09@gmail.com>

To: vignesh C <vignesh21@gmail.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, e.indrupskaya@postgrespro.ru

Date: 2023-02-20T07:35:52Z

Lists: pgsql-hackers

Attachments

v4-0010-Proposed-reworking-of-SQL-JSON-documentaion.patch (application/octet-stream) patch v4-0010
v4-0008-Documentation-for-SQL-JSON-features.patch (application/octet-stream) patch v4-0008
v4-0006-JSON_TABLE.patch (application/octet-stream) patch v4-0006
v4-0009-Claim-SQL-standard-compliance-for-SQL-JSON-featur.patch (application/octet-stream) patch v4-0009
v4-0007-PLAN-clauses-for-JSON_TABLE.patch (application/octet-stream) patch v4-0007
v4-0005-RETURNING-clause-for-JSON-and-JSON_SCALAR.patch (application/octet-stream) patch v4-0005
v4-0004-SQL-JSON-functions.patch (application/octet-stream) patch v4-0004
v4-0003-SQL-JSON-query-functions.patch (application/octet-stream) patch v4-0003
v4-0001-SQL-JSON-constructors.patch (application/octet-stream) patch v4-0001
v4-0002-IS-JSON-predicate.patch (application/octet-stream) patch v4-0002

Hi,

On Mon, Jan 30, 2023 at 3:39 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Fri, Jan 27, 2023 at 11:27 PM vignesh C <vignesh21@gmail.com> wrote:
> > On Tue, 17 Jan 2023 at 19:01, Amit Langote <amitlangote09@gmail.com> wrote:
> > > And I've just finished doing that.  In the attached updated 0004,
> > > which adds the JsonExpr node, its evaluation code is now broken into
> > > ExprEvalSteps to handle the subsidiary JsonCoercion and JsonBehavior
> > > expression nodes that previously used ExprState for recursive
> > > evaluation.  Andres didn't like the latter as previously discussed at
> > > [1].
> > >
> > > I've also attached the patch that Elena has proposed as the patch
> > > 0011.  I haven't managed to review it yet, though once I do, I'll
> > > merge it into the main documentation patch 0009.  Thanks Elena.
> >
> > The patch does not apply on top of HEAD as in [1], please post a rebased patch:
>
> Thanks for the heads up.  Here's a rebased version.

Rebased again over queryjumble overhaul.

I decided to squash what was "[PATCH v3 01/11] Common SQL/JSON
clauses" into "[PATCH v3 02/11] SQL/JSON constructors", because I
noticed "useless productions" warnings against its gram.y additions
when building just 0001.

I also looked at squashing "[PATCH v3 11/11] Proposed reworking of
SQL/JSON documentaion" into "[PATCH v3 09/11] Documentation for
SQL/JSON features", but didn't, again, because I am still not sure
which one of <parameter> and <replaceable> is correct for the SQL/JSON
function constructs.  Maybe it's the latter looking at the markup for
some text on [1], such as exists ( path_expression ) → boolean, but
Andrew sounded doubtful about that upthread.

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

[1] https://www.postgresql.org/docs/15/functions-json.html

Commits

Add SQL/JSON query functions
- 6185c9737cf4 17.0 landed
Add soft error handling to some expression nodes
- aaaf9449ec6b 17.0 landed
Adjust populate_record_field() to handle errors softly
- 1edb3b491bee 17.0 landed
Refactor code used by jsonpath executor to fetch variables
- faa2b953ba3b 17.0 landed
Code review for recent SQL/JSON commits
- 71bfd1543f8b 16.0 landed
Fix inconsistencies and style issues in new SQL/JSON code
- 60966f56c3e4 16.0 landed
Don't install postmaster symlink anymore
- 37e267335068 16.0 cited
Revert SQL/JSON features
- 2f2b18bd3f55 16.0 cited
Doc: standardize markup a bit more.
- 47046763c3ed 13.0 cited