Re: adding partitioned tables to publications
amit <amitlangote09@gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Petr Jelinek <petr@2ndquadrant.com>,
Rafia Sabih <rafia.pghackers@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-04-17T14:58:08Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix RELCACHE_FORCE_RELEASE issue
- 12fb189bfeaf 13.0 landed
-
Allow publishing partition changes via ancestors
- 83fd4532a721 13.0 landed
-
Add logical replication support to replicate into partitioned tables
- f1ac27bfda6c 13.0 landed
-
Refactor code to look up local replication tuple
- d8653f468789 13.0 landed
-
Some refactoring of logical/worker.c
- 97ee604d9bce 13.0 landed
-
Prepare to support non-tables in publications
- c314c147c056 13.0 landed
-
Support adding partitioned tables to publication
- 17b9e7f9fe23 13.0 landed
Attachments
- 0001-Rearrange-some-code-in-pgoutput.c.patch (application/octet-stream) patch 0001
- 0002-Fix-partition-logical-replication-TAP-tests-for-bett.patch (application/octet-stream) patch 0002
On Fri, Apr 17, 2020 at 10:23 PM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > On 2020-04-09 09:28, Amit Langote wrote: > > While figuring this out, I thought the nearby code could be rearranged > > a bit, especially to de-duplicate the code. Also, I think > > get_rel_sync_entry() may be a better place to set the map, rather than > > maybe_send_schema(). Thoughts? > > because I didn't really have an opinion on that at the time, but if you > still want it considered or have any open thoughts on this thread, > please resend or explain. Sure, thanks for taking care of the bug. Rebased the code rearrangement patch. Also resending the patch to fix TAP tests for improving coverage as described in: https://www.postgresql.org/message-id/CA%2BHiwqFyydvQ5g%3Dqa54UM%2BXjm77BdhX-nM4dXQkNOgH%3DzvDjoA%40mail.gmail.com To summarize: 1. Missing coverage for a couple of related blocks in apply_handle_tuple_routing() 2. Missing coverage report for the code in pgoutput.c added by 83fd4532 -- Amit Langote EnterpriseDB: http://www.enterprisedb.com