Re: assert pg_class.relnatts is consistent

Amit Langote <amitlangote09@gmail.com>

From: Amit Langote <amitlangote09@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Justin Pryzby <pryzby@telsasoft.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2020-02-14T09:00:05Z

Lists: pgsql-hackers

Attachments

0001-Don-t-require-relnatts-to-be-specified-in-pg_class.d.patch (text/plain) patch 0001

On Fri, Feb 14, 2020 at 2:58 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Fri, Feb 14, 2020 at 1:04 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I've been burnt by this too :-(.  However, I think this patch is
> > completely the wrong way to go about improving this.  What we should
> > be doing, now that we have all that perl code generating postgres.bki,
> > is eliminating the problem at the source.  That is, drop the hand-coded
> > relnatts values from pg_class.dat altogether, and let the perl code fill
> > it in --- compare the handling of pg_proc.pronargs for instance.
>
> I can't write Perl myself (maybe Justin), but +1 to this idea.

I tried and think it works but not sure if that's good Perl
programming.  See the attached.

Thanks,
Amit

Commits

Update obsolete comment.
- faade5d4c6d8 13.0 landed
Clarify coding in Catalog::AddDefaultValues.
- 9d1ec5a8e155 13.0 landed
Run "make reformat-dat-files".
- b78542b9e975 13.0 landed
Don't require pg_class.dat to contain correct relnatts values.
- 86ff085e8388 13.0 landed