Re: Reserve prefixes for loaded libraries proposal
Florin Irion <irionr@gmail.com>
From: Florin Irion <irionr@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Chapman Flack <chap@anastigmatix.net>, pgsql-hackers@postgresql.org, laurenz.albe@cybertec.at
Date: 2021-12-01T17:47:40Z
Lists: pgsql-hackers
> > Committed. > > I made two notable changes: I renamed the function, since it looked > like EmitWarningsOnPlaceholders() but was doing something not analogous. Also, you had in your function > > strncmp(varName, var->name, varLen) > > probably copied from EmitWarningsOnPlaceholders(), but unlike there, we > want to compare the whole string here, and this would potentially do > something wrong if there were a GUC setting that was a substring of the > name of another one. > Yeah, it makes sense! Thank you very much! Thank you for the changes and thank you for committing it! Cheers, Florin -- *Florin Irion* *www.enterprisedb.com <http://www.enterprisedb.com>* Cel: +39 328 5904901 Tel: +39 0574 054953 Via Alvise Cadamosto, 47 59100, Prato, PO Italia
Commits
-
Warning on SET of nonexisting setting with a prefix reserved by an extension
- 75d22069e00d 15.0 landed