Horton

Re: Retrieving query results

Igor Korot <ikorot01@gmail.com>

View thread View on postgr.es
From: Igor Korot <ikorot01@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-general <pgsql-general@postgresql.org>
Date: 2017-08-24T23:05:22Z
Lists: pgsql-general 
Michael et al,

On Thu, Aug 24, 2017 at 6:57 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Thu, Aug 24, 2017 at 11:56 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I haven't tried it, but it sure looks like it would, if you don't hit
>> OOM first.  pqAddTuple() isn't doing anything to guard against integer
>> overflow.  The lack of reports implies that no one has ever tried to
>> retrieve even 1G rows, let alone more ...
>
> Yeah, looking at the code we would just need to check if ntups gets
> negative (well, equal to INT_MIN) after being incremented.

So there is no way to retrieve an arbitrary number of rows from the query?
That sucks...

Thank you.

> --
> Michael

Commits

  1. Doc: document libpq's restriction to INT_MAX rows in a PGresult.

  2. Teach libpq to detect integer overflow in the row count of a PGresult.