Re: [Proposal] Global temporary tables

Wenjing Zeng <wjzeng2012@gmail.com>

From: Wenjing Zeng <wjzeng2012@gmail.com>

To: Andrew Bille <andrewbille@gmail.com>

Cc: wenjing <wenjing@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, Tony Zhu <Tony.zhu@ww-it.cn>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-01-20T09:53:05Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

PageAddItemExtended(): Add LP_UNUSED assertion.
- 30aaab26e521 14.0 cited
Remove temporary files after backend crash
- cd91de0d1795 14.0 cited
Fix comment in indexing.c
- 9fd2952cf492 14.0 cited
Fix failure to ignore leftover temp tables after a server crash.
- 6919b7e32947 9.3.0 cited

Attachments

0001-gtt-v65-reademe.patch (application/octet-stream) patch v65-0001
0002-gtt-v65-doc.patch (application/octet-stream) patch v65-0002
0003-gtt-v65-implementation.patch (application/octet-stream) patch v65-0003
0004-gtt-v65-regress.patch (application/octet-stream) patch v65-0004

very glad to see your reply.
Thank you very much for your review of the code and found so many problems.
There was a conflict between the latest code and patch, I have corrected it
and provided a new patch (V65).
Waiting for your feedback.


Regards, Wenjing.


Andrew Bille <andrewbille@gmail.com> 于2022年1月10日周一 17:17写道：

> Hi!
>
> I could not detect crashes with your last patch, so I think the patch is
> ready for a review.
> Please, also consider fixing error messages, as existing ones don't follow
> message writing guidelines.
> https://www.postgresql.org/docs/14/error-style-guide.html
>

I corrected the ERROR message of GTT according to the link and the existing
error message.
Some comments and code refactoring were also done.


>
> Regards, Andrew
>
> On Thu, Dec 23, 2021 at 7:36 PM wenjing <wjzeng2012@gmail.com> wrote:
>
>>
>>
>> Andrew Bille <andrewbille@gmail.com> 于2021年12月21日周二 14:00写道：
>>
>>> Hi!
>>> Thanks for new patches.
>>> Yet another crash reproduced on master with v63 patches:
>>>
>>> CREATE TABLESPACE ts LOCATION '/tmp/ts';
>>> CREATE GLOBAL TEMP TABLE tbl (num1 bigint);
>>> INSERT INTO tbl (num1) values (1);
>>> CREATE INDEX tbl_idx ON tbl (num1);
>>> REINDEX (TABLESPACE ts) TABLE tbl;
>>>
>> This is a feature made in PG14 that supports reindex change tablespaces.
>> Thank you for pointing that out and I fixed it in v64.
>> Waiting for your feedback.
>>
>