Horton

Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection

Heath Lord <heath.lord@crunchydata.com>

View thread View on postgr.es
From: Heath Lord <heath.lord@crunchydata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Jacob Champion <jchampion@timescale.com>, pgsql-bugs@lists.postgresql.org
Date: 2022-09-29T20:21:59Z
Lists: pgsql-bugs 
On Thu, Sep 29, 2022 at 4:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> I wrote:
> > AFAICS that behavioral change is deliberate: for the single case
> > of inquiring about "library", PQsslAttribute now tells you which
> > SSL implementation libpq *can* use, not which one it's actually
> > using on a given connection.  I'm not sure that this is a great
> > definition, since it's so unlike the behavior for other attributes.
>
> Actually, wait a minute: both the documentation and the commit
> message claim the new behavior is something different than what it
> actually is.  The intention seems to have been to change the
> behavior only for the conn == NULL case.  So maybe we need to
> fix it as attached.  This'd still be broken for the
> multiple-libraries scenario, but I admit that that's pretty
> hypothetical.
>
>                         regards, tom lane
>
>
Tom,

   I was in the process of drafting a reply, but this new patch seems to
resolve my issues with the documentation and functionality. I really
appreciate you looking into this and I am good with this patch.

Thanks,
   Heath

Commits

  1. Adjust PQsslAttributeNames() to match PQsslAttribute().

  2. doc: Fix PQsslAttribute docs for compression

  3. Fix bogus behavior of PQsslAttribute(conn, "library").

  4. Enable SSL library detection via PQsslAttribute()