Horton

Thread

Commits

  1. Fix grammatical typos around possessive "its"

  1. Comment cleanup - it's vs its

    Jacob Brazeal <jacob.brazeal@gmail.com> — 2025-01-29T06:46:35Z

    I noticed a few incorrect usages of it's vs its and decided to search
systematically for any mistakes. Overall, we use it right more than 99% of
the time but there were still about 20 mistakes.

Jacob

  2. Re: Comment cleanup - it's vs its

    John Naylor <johncnaylorls@gmail.com> — 2025-01-29T07:15:02Z

    On Wed, Jan 29, 2025 at 1:46 PM Jacob Brazeal <jacob.brazeal@gmail.com> wrote:
>
> I noticed a few incorrect usages of it's vs its and decided to search systematically for any mistakes. Overall, we use it right more than 99% of the time but there were still about 20 mistakes.

LGTM, except maybe this one:

- * try read non-locale sign, it's happen only if format is not exact
+ * try read non-locale sign, it happens only if format is not exact

...sounds better to me with "which happens".

-- 
John Naylor
Amazon Web Services

  3. Re: Comment cleanup - it's vs its

    John Naylor <johncnaylorls@gmail.com> — 2025-01-29T07:23:50Z

    On Wed, Jan 29, 2025 at 1:46 PM Jacob Brazeal <jacob.brazeal@gmail.com> wrote:
>
> I noticed a few incorrect usages of it's vs its and decided to search systematically for any mistakes. Overall, we use it right more than 99% of the time but there were still about 20 mistakes.

I just noticed this, too:

-# DROP DATABASE should drops it's slots, including active slots.
+# DROP DATABASE should drops its slots, including active slots.

"should drop"

-- 
John Naylor
Amazon Web Services

  4. Re: Comment cleanup - it's vs its

    John Naylor <johncnaylorls@gmail.com> — 2025-01-29T07:50:27Z

    On Wed, Jan 29, 2025 at 2:26 PM Jacob Brazeal <jacob.brazeal@gmail.com> wrote:
>
> > I just noticed this, too:
> >
> > -# DROP DATABASE should drops it's slots, including active slots.
> > +# DROP DATABASE should drops its slots, including active slots.
> >
> > "should drop"
>
> Ah, good catch. Fixed in v3.

(Note: You forgot reply-all for your later messages). I ran pgindent
after applying and found it re-indented an entire paragraph. That
seemed like an unfortunate side-effect for a typo fix, so I took the
liberty of adding an additional space after a period. Some comments
use the two-space style anyway. Pushed, thanks for the patch!

--
John Naylor
Amazon Web Services