Thread

1. [PATCH] Fix missing pfree(flags.data) in overexplain_debug

   Lakshmi N <lakshmin.jhs@gmail.com> — 2026-04-13T20:33:11Z

   Hi hackers,
   
   attached a small patch to fix missing  pfree(flags.data) in
   overexplain_debug.
   
   Regards,
   Lakshmi
   

2. Re: [PATCH] Fix missing pfree(flags.data) in overexplain_debug

   Heikki Linnakangas <hlinnaka@iki.fi> — 2026-04-14T09:20:15Z

   On 13/04/2026 23:33, Lakshmi N wrote:
   > Hi hackers,
   > 
   > attached a small patch to fix missing  pfree(flags.data) in 
   > overexplain_debug.
   
   These leaks are to a relatively short-lived memory context. We don't 
   need to meticulously pfree() those, they will go away with the memory 
   context. There are also numerous psprintf() calls in the function and in 
   the subroutines which are not pfreed, for example.
   
   We're not totally consistent, as there are pfree() calls in some of the 
   subroutines. I don't know if there's some grand plan on when to pfree() 
   and when not to bother, but this one pfree() won't move the needle much 
   in any case.
   
   - Heikki