Re: Allow logical failover slots to wait on synchronous replication

John H <johnhyvr@gmail.com>

From: John H <johnhyvr@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-08-26T19:31:53Z
Lists: pgsql-hackers
Hi Bertrand,

On Sun, Jul 28, 2024 at 10:00 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:

> Yeah, at the same place as the static lsn[] declaration, something like:
>
> static XLogRecPtr       lsn[NUM_SYNC_REP_WAIT_MODE]; /* cached LSNs */
>
> but that may just be a matter of taste.
>

I've updated the patch to reflect that.

>
> Right, we may want to cast it then but given that the for loop is "small" I think
> that's also fine to keep the for loop.
>

Ah I see what you mean. I've updated these changes and attached the
patch to the other thread.


Thanks,
-- 
John Hsu - Amazon Web Services