Horton

Re: [PATCH] Check more invariants during syscache initialization

Zhang Mingli <zmlpostgres@gmail.com>

View thread View on postgr.es
From: Zhang Mingli <zmlpostgres@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-27T01:48:10Z
Lists: pgsql-hackers 
Hi,

> On Jul 27, 2023, at 09:05, Michael Paquier <michael@paquier.xyz> wrote:
> 
>  One reason is that this increases the odds of
> conflicts when backpatching on a stable branch.

Agree. We could suggest to use OidIsValid() for new patches during review.

Zhang Mingli
https://www.hashdata.xyz

Commits

  1. Add sanity asserts for index OID and attnums during cache init