Horton

Re: Elimination of the repetitive code at the SLRU bootstrap functions.

Andrey Borodin <x4mmm@yandex-team.ru>

View thread
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Evgeny <evorop@gmail.com>
Cc: Álvaro Herrera <alvherre@alvh.no-ip.org>, Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-03-12T06:25:47Z
Lists: pgsql-hackers 

> On 11 Mar 2025, at 14:12, Evgeny <evorop@gmail.com> wrote:
> 


Hi!

Some nits:

Patch adds whitespace errors
.git/rebase-apply/patch:64: trailing whitespace.
* Nullify the page (pageno = 0), don't insert an XLog record,  .git/rebase-apply/patch:212: trailing whitespace.
/*  .git/rebase-apply/patch:213: trailing whitespace.
* Zero the page;  .git/rebase-apply/patch:250: trailing whitespace.
.git/rebase-apply/patch:349: trailing whitespace.
* Nullify the page (pageno = 0), don't insert an XLog record,  warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.

if (writePage != 0) should be if (writePage)

XLogSimpleInsert(int64 simpledata, RmgrId rmid, uint8 info)
I’d rename function XLogSimpleInsert() to something more descriptive and changed arguments order from generic to specific. Probably, committer has broader view on XLog routines and can decide if this function would better belong to SLRU than common XLog stuff.

Besides this patch seems ready to me.

Thanks!


Best regards, Andrey Borodin.