Re: [Proposal] Add accumulated statistics for wait event
Imai Yoshikazu <yoshikazu_i443@live.jp>
From: Imai Yoshikazu <yoshikazu_i443@live.jp>
To: Pavel Stehule <pavel.stehule@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Cc: Yoshikazu Imai <imai.yoshikazu@fujitsu.com>
Date: 2020-01-15T13:15:47Z
Lists: pgsql-hackers
Attachments
- 0001-Add-pg_stat_waitaccum-view-v4.patch (text/plain) patch v4-0001
- 0002-POC-Change-measuring-method-of-wait-event-time-fr-v4.patch (text/plain) patch v4-0002
On 2020/01/13 4:11, Pavel Stehule wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation: tested, passed > > I like this patch, because I used similar functionality some years ago very successfully. The implementation is almost simple, and the result should be valid by used method. Thanks for your review! > The potential problem is performance impact. Very early test show impact cca 3% worst case, but I'll try to repeat these tests. Yes, performance impact is the main concern. I want to know how it affects performance in various test cases or on various environments. > There are some ending whitespaces and useless tabs. > > The new status of this patch is: Waiting on Author I attach v4 patches removing those extra whitespaces of the end of lines and useless tabs. -- Yoshikazu Imai