Horton

Re: [HACKERS] INSERT ON CONFLICT and partitioned tables

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-12-07T05:10:45Z
Lists: pgsql-hackers 
On 2017/12/02 2:57, Robert Haas wrote:
> On Fri, Dec 1, 2017 at 2:44 AM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> I forgot to consider the fact that mtstate could be NULL in
>> ExecSetupPartitionTupleRouting(), so would result in dereferencing NULL
>> pointer when called from CopyFrom(), which fixed in the attached updated
>> patch.
> 
> a ? b : false can more simply be spelled a && b.
> 
> Committed after changing it like that, fixing the broken documentation
> build, and making minor edits to the comments and documentation.

Thanks for committing.

Regards,
Amit

Commits

  1. Re-allow INSERT .. ON CONFLICT DO NOTHING on partitioned tables.