Re: speeding up planning with partitions

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

To: "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>, "'Amit Langote'" <amitlangote09@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <david.rowley@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Justin Pryzby <pryzby@telsasoft.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Jesper Pedersen <jesper.pedersen@redhat.com>

Date: 2019-03-19T06:53:19Z

Lists: pgsql-hackers

Attachments

v32-0001-Build-other-rels-of-appendrel-baserels-in-a-sepa.patch (text/plain) patch v32-0001
v32-0002-Add-rowmark-junk-targetlist-entries-in-query_pla.patch (text/plain) patch v32-0002
v32-0003-Delay-adding-inheritance-child-tables-until-quer.patch (text/plain) patch v32-0003
v32-0004-Adjust-inheritance_planner-to-reuse-source-child.patch (text/plain) patch v32-0004
v32-0005-Further-tweak-inheritance_planner-to-avoid-usele.patch (text/plain) patch v32-0005
v32-0006-Perform-pruning-in-expand_partitioned_rtentry.patch (text/plain) patch v32-0006
v32-0007-Teach-planner-to-only-process-unpruned-partition.patch (text/plain) patch v32-0007
v32-0008-Don-t-copy-PartitionBoundInfo-in-set_relation_pa.patch (text/plain) patch v32-0008

Imai-san,

On 2019/03/15 9:33, Imai, Yoshikazu wrote:
> On Thu, Mar 14, 2019 at 9:04 AM, Amit Langote wrote:
>>> * In inheritance_planner(), we do ChangeVarNodes() only for orig_rtable,
>> so the codes concatenating lists of append_rel_list may be able to be
>> moved before doing ChangeVarNodes() and then the codes concatenating
>> lists of rowmarks, rtable and append_rel_list can be in one block (or
>> one bunch).
>>
>> Yeah, perhaps.  I'll check.

I'm inclined to add source_appinfos to subroot->append_rel_list after
finishing the ChangeVarNodes(subroot->append_rel_list) step, because if
there are many entries in source_appinfos that would unnecessarily make
ChangeVarNodes take longer.

>> On 2019/03/14 17:35, Imai, Yoshikazu wrote:> Amit-san,
>>> I have done code review of v31 patches from 0004 to 0008.
>>>
>>> 0004:
>>> * s/childern/children
>>
>> Will fix.

Fixed.

I've attached updated patches.  In the new version, I've moved some code
from 0004 to 0005 patch, so as to avoid mixing unrelated modifications in
one patch.  Especially, orig_rtable now only appears after applying 0005.

I appreciate your continued interest in these patches.

Thanks,
Amit

Commits

Clean up handling of constraint_exclusion and enable_partition_pruning.
- e03ff739695c 12.0 landed
- 11ea45ffec9a 11.3 landed
Add test case exercising formerly-unreached code in inheritance_planner.
- 8fba397f0ca7 12.0 landed
Speed up planning when partitions can be pruned at plan time.
- 428b260f87e8 12.0 landed
Avoid crash in partitionwise join planning under GEQO.
- 7ad6498fd5a6 12.0 landed
- d70c147fa217 11.3 landed
Avoid passing query tlist around separately from root->processed_tlist.
- 333ed246c6f3 12.0 landed
Build "other rels" of appendrel baserels in a separate step.
- 53bcf5e3dbea 12.0 landed
Get rid of duplicate child RTE for a partitioned table.
- e8d5dd6be79e 12.0 landed
Rearrange make_partitionedrel_pruneinfo to avoid work when we can't prune.
- 734308a22072 12.0 landed
Don't copy PartitionBoundInfo in set_relation_partition_info.
- c8151e642368 12.0 landed
Move building of child base quals out into a new function
- 80579f9bb171 12.0 landed
Reorganize planner code moved in b60c39759908
- d723f56872a9 12.0 landed
Move inheritance expansion code into its own file
- b60c39759908 12.0 landed
Fix inherited UPDATE/DELETE with UNION ALL subqueries.
- c03ad5602f52 9.4.0 cited
Rearrange planner to save the whole PlannerInfo (subroot) for a subquery.
- b3aaf9081a1a 9.2.0 cited