Horton

Re: Weird test mixup

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-03-15T15:56:14Z
Lists: pgsql-hackers 
On 15/03/2024 16:00, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> On 15/03/2024 13:09, Heikki Linnakangas wrote:
>>> I committed a patch to do that, to put out the fire.
> 
>> That's turning the buildfarm quite red. Many, but not all animals are
>> failing like this:
> 
> It may be even worse than it appears from the buildfarm status page.
> My animals were stuck in infinite loops that required a manual "kill"
> to get out of, and it's reasonable to assume there are others that
> will require owner intervention.  Why would this test have done that,
> if the module failed to load?

The gin_incomplete_split test inserts rows until it hits the injection 
point, at page split. There is a backstop, it should give up after 10000 
iterations, but that was broken. Fixed that, thanks for the report!

Hmm, don't we have any timeout that would kill tests if they get stuck?

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. injection_points: Store runtime conditions in private area

  2. Introduce private data area for injection points

  3. injection_points: Fix incorrect spinlock acquisition

  4. Make GIN tests using injection points concurrent-safe

  5. injection_points: Fix race condition with local injection point tests

  6. injection_points: Introduce runtime conditions

  7. Make GIN test using injection points repeatable

  8. Fix backstop in gin test if injection point is not reached

  9. Try to unbreak injection-fault tests in the buildfarm

  10. Disable tests using injection points in installcheck