Horton

Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

Andrei Lepikhov <a.lepikhov@postgrespro.ru>

View thread
From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
To: Andrei Zubkov <zubkov@moonset.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-10-25T06:59:09Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve quoting in some error messages

On 19/10/2023 19:40, Andrei Zubkov wrote:
> Hi hackers,
> 
> New version 23 attached. It contains rebase to the current master.

I discovered the patch and parameters you've proposed. In my opinion, 
the stats_since parameter adds valuable information and should 
definitely be included in the stats data because the statement can be 
noteless removed from the list and inserted again.
But minmax_stats_since and changes in the UI of the reset routine look 
like syntactic sugar here.
I can't convince myself that it is really needed. Do you have some set 
of cases that can enforce the changes proposed? Maybe we should 
intensively work on adding the 'stats_since' parameter and continue the 
discussion of the necessity of another one?

-- 
regards,
Andrei Lepikhov
Postgres Professional