Horton
Menu

Re: pg_hba_file_settings view patch

Joshua D. Drake <jd@commandprompt.com>

View thread
From: "Joshua D. Drake" <jd@commandprompt.com>
To: Josh Berkus <josh@agliodbs.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Haribabu Kommi <kommi.haribabu@gmail.com>, Michael Paquier <michael.paquier@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-10-26T20:04:15Z
Lists: pgsql-hackers 
On 10/26/2016 12:54 PM, Josh Berkus wrote:
> On 10/26/2016 12:24 PM, Tom Lane wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> FWIW, I'm -1 on using JSON here.  I don't believe that we should start
>>> using JSON all over the place just because we can.  If we do that,
>>> we'll end up with a mishmash of styles, and maybe look silly when JSON
>>> is replaced by the new and much better SDGJHSDR format.
>>
>> I concur.  JSON isn't a core datatype and I don't want to see it treated
>> as one.  We should redesign this view so that it doesn't rely on anything
>> more advanced than arrays.
>
> Huh?  Sure it is.   Ships in PostgreSQL-core.
>
> I mean, I'm not particularly in favor of using JSON for this (arrays
> seem OK), but that seems like an invalid reason not to.

-1 to JSON for this.

JD

>


-- 
Command Prompt, Inc.                  http://the.postgres.company/
                         +1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.
Unless otherwise stated, opinions are my own.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Invent pg_hba_file_rules view to show the content of pg_hba.conf.

  2. Restructure hba.c to replace 3 parallel lists with single list of structs.