Re: WIP: Covering + unique indexes.

Erik Rijkers <er@xs4all.nl>

From: Erik Rijkers <er@xs4all.nl>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-03-28T15:25:32Z
Lists: pgsql-hackers
On 2018-03-28 16:59, Anastasia Lubennikova wrote:
> Here is the new version of the patch set.

I can't get these to apply:

patch -b -l -F 25 -p 1 < 
/home/aardvark/download/pgpatches/0110/covering_indexes/20180328/0001-Covering-core-v8.patch


1 out of 19 hunks FAILED -- saving rejects to file 
src/backend/utils/cache/relcache.c.rej


$ cat src/backend/utils/cache/relcache.c.rej
--- src/backend/utils/cache/relcache.c
+++ src/backend/utils/cache/relcache.c
@@ -542,7 +542,7 @@
                 attp = (Form_pg_attribute) 
GETSTRUCT(pg_attribute_tuple);

                 if (attp->attnum <= 0 ||
-                       attp->attnum > relation->rd_rel->relnatts)
+                       attp->attnum > 
RelationGetNumberOfAttributes(relation))
                         elog(ERROR, "invalid attribute number %d for 
%s",
                                  attp->attnum, 
RelationGetRelationName(relation));





Erik Rijkers



Commits

  1. Adjust INCLUDE index truncation comments and code.

  2. Add commentary explaining why MaxIndexTuplesPerPage calculation is safe.

  3. Indexes with INCLUDE columns and their support in B-tree

  4. Add amcheck verification of heap relations belonging to btree indexes.

  5. Doc: move info for btree opclass implementors into main documentation.

  6. Doc: mention that you can't PREPARE TRANSACTION after NOTIFY.

  7. Remove dedicated B-tree root-split record types.

  8. Restructure index access method API to hide most of it at the C level.

  9. Split _bt_insertonpg to two functions.

  10. Major overhaul of btree index code. Eliminate special BTP_CHAIN logic for