Horton

Re: ecpg command does not warn COPY ... FROM STDIN;

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Ryo Kanbayashi <kanbayashi.dev@gmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2025-01-14T16:34:49Z
Lists: pgsql-hackers 

On 2025/01/12 18:27, Ryo Kanbayashi wrote:
> Thank you for reviewing patch :)
> The commit log matches with my recognition and has no problem.

Pushed. Thanks!

>>> check_patches.sh -> utility script for testing above two patches on
>>> each target branches
>>
>> Should we add a regression test to ensure ecpg correctly reports errors
>> and warnings, including the warning for COPY FROM STDIN? This could help
>> catch similar bugs more effectively. If agreed, we could create this
>> as a separate patch.
> 
> Of course there is no problem!
> I think a test like above becomes a good regression test too.

So, will you give creating the patch a try?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. ecpg: Restore detection of unsupported COPY FROM STDIN.

  2. plpgsql: pure parser and reentrant scanner

  3. Add support for piping COPY to/from an external program.