Re: Fix error handling in be_tls_open_server()

Sergey Shinderuk <s.shinderuk@postgrespro.ru>

From: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-08-24T09:13:18Z
Lists: pgsql-hackers
On 24.08.2023 11:38, Daniel Gustafsson wrote:
>> On 24 Aug 2023, at 10:11, Sergey Shinderuk <s.shinderuk@postgrespro.ru> wrote:

>> I triggered a crash by generating a certificate without a CN and forcing malloc to return NULL when called from X509_NAME_print_ex or BIO_get_mem_ptr with gdb.
> 
> Can you extend the patch with that certificate and a test using it?  The
> certificates are generated from config files kept in the repo in src/test/ssl
> in order to be reproducible.

But I need to force malloc to fail at the right time during the test. I 
don't think I can make a stable and portable test from this.


-- 
Sergey Shinderuk		https://postgrespro.com/




Commits

  1. Avoid potential pfree on NULL on OpenSSL errors