Re: updates for handling optional argument in system functions

Andreas Karlsson <andreas@proxel.se>

From: Andreas Karlsson <andreas@proxel.se>

To: Mark Wong <markwkm@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2026-04-07T23:28:29Z

Lists: pgsql-hackers

Attachments

v6-0001-Handle-pg_get_ruledef-default-args-in-system_func.patch (text/x-patch) patch v6-0001
v6-0002-Handle-pg_get_viewdef-default-args-in-system_func.patch (text/x-patch) patch v6-0002
v6-0003-Handle-pg_get_indexdef-default-args-in-system_fun.patch (text/x-patch) patch v6-0003
v6-0004-Handle-pg_get_constraintdef-default-args-in-syste.patch (text/x-patch) patch v6-0004
v6-0005-Handle-pg_get_expr-default-args-in-system_functio.patch (text/x-patch) patch v6-0005
v6-0006-Handle-pg_get_triggerdef-default-args-in-system_f.patch (text/x-patch) patch v6-0006

On 4/8/26 12:26 AM, Andreas Karlsson wrote:
> On 4/2/26 8:36 PM, Mark Wong wrote:
>> I've attached v5, simply a needed rebase due to some other churn in
>> pg_proc.dat.
> 
> Nice, I like the patch. The code changes looks good and I like the 
> removal of these duplicate functions and use of default arguments. But I 
> think the names of the arguments should be aligned with the names we 
> have in the documentation. And that may mean that we should change the 
> documentation.
Forgot to attach rebased patches.

-- 
Andreas Karlsson
Percona

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Simplify creation of built-in functions with default arguments.
- 759b03b24ce9 19 (unreleased) cited