Re: Use CASEFOLD() internally rather than LOWER()
Jeff Davis <pgsql@j-davis.com>
From: Jeff Davis <pgsql@j-davis.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2026-01-14T19:53:42Z
Lists: pgsql-hackers
On Tue, 2026-01-13 at 10:14 +0800, Chao Li wrote: > 1 - 0001 > ``` > +SELECT U&'straße' ILIKE U&'STRASSE' COLLATE PG_C_UTF8; > ``` > > Do we want to added one more test: > ``` > SELECT U&'straße' ILIKE U&'STRASSE' COLLATE PG_UNICODE_FAST; > ?column? > ---------- > t > (1 row) > ``` > Which tests the different behaviors against collations. I am confused, doesn't the patch already have both of those tests for both collations? What change are you suggesting? > I initially thought to add test cases with different collations, but > after debugging, I found that citext intentionally ignores specified > collation. Adding a test that's dependent on the database-wide collation is more heavyweight because it needs to create a new database. Regards, Jeff Davis