Horton

Thread

Commits

  1. Fix code comments still referring to pg_start/stop_backup()

  1. Comments referring to pg_start/stop_backup

    Michael Paquier <michael@paquier.xyz> — 2022-06-28T04:41:58Z

    Hi all,

While browsing through the recent changes with the base backup APIs, I
have noticed that a couple of comments did not get the renaming of the
SQL functions to pg_backup_start/stop, as of the attached.

That's not a big deal, but let's be right.

Thanks,
--
Michael

  2. Re: Comments referring to pg_start/stop_backup

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2022-06-28T05:00:57Z

    At Tue, 28 Jun 2022 13:41:58 +0900, Michael Paquier <michael@paquier.xyz> wrote in 
> Hi all,
> 
> While browsing through the recent changes with the base backup APIs, I
> have noticed that a couple of comments did not get the renaming of the
> SQL functions to pg_backup_start/stop, as of the attached.
> 
> That's not a big deal, but let's be right.

+1 and I don't find other instances of the same mistake.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  3. Re: Comments referring to pg_start/stop_backup

    David Steele <david@pgmasters.net> — 2022-06-28T11:47:04Z

    On 6/28/22 01:00, Kyotaro Horiguchi wrote:
> At Tue, 28 Jun 2022 13:41:58 +0900, Michael Paquier <michael@paquier.xyz> wrote in
>> Hi all,
>>
>> While browsing through the recent changes with the base backup APIs, I
>> have noticed that a couple of comments did not get the renaming of the
>> SQL functions to pg_backup_start/stop, as of the attached.
>>
>> That's not a big deal, but let's be right.
> 
> +1 and I don't find other instances of the same mistake.

Yes, these also look good to me. They are a bit tricky to search for so 
I can see how we missed them.

Regards,
-David

  4. Re: Comments referring to pg_start/stop_backup

    Michael Paquier <michael@paquier.xyz> — 2022-07-01T00:57:56Z

    On Tue, Jun 28, 2022 at 07:47:04AM -0400, David Steele wrote:
> Yes, these also look good to me. They are a bit tricky to search for so I
> can see how we missed them.

Thanks for double-checking.  Applied.
--
Michael