Horton

Re: ECPG cleanup and fix for clang compile-time problem

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>, John Naylor <johncnaylorls@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Andres Freund <andres@anarazel.de>, Michael Paquier <michael.paquier@gmail.com>
Date: 2024-08-15T07:20:13Z
Lists: pgsql-hackers 
On 15.08.24 02:43, Tom Lane wrote:
> I wrote:
>> Here's a rebased but otherwise identical patchset.  I also added
>> an 0007 that removes check_rules.pl as threatened.
> 
> I've done some more work on this and hope to post an updated patchset
> tomorrow.  Before that though, is there any objection to going ahead
> with pushing the 0001 patch (pgindent'ing ecpg's lexer and parser
> files)?  It's pretty bulky yet of no intellectual interest, so I'd
> like to stop carrying it forward.

The indentation patch looks good to me and it would be good to get it 
out of the way.

Commits

  1. ecpg: clean up some other assorted memory leaks.

  2. ecpg: fix some memory leakage of data-type-related structures.

  3. ecpg: put all string-valued tokens returned by pgc.l in local storage.

  4. ecpg: fix more minor mishandling of bad input in preprocessor.

  5. ecpg: fix some minor mishandling of bad input in preprocessor.

  6. ecpg: avoid breaking the IDENT precedence level in two.

  7. ecpg: improve preprocessor's memory management.

  8. ecpg: move some functions into a new file ecpg/preproc/util.c.

  9. ecpg: re-implement preprocessor's string management.

  10. ecpg: major cleanup, simplification, and documentation of parse.pl.

  11. ecpg: remove check_rules.pl.

  12. ecpg: clean up documentation of parse.pl, and add more input checking.

  13. Clean up indentation and whitespace inconsistencies in ecpg.

  14. Exclude flex-generated code from coverage testing