Thread

  1. .gitignore for some of cygwin files

    Radosław Smogura <rsmogura@softperience.eu> — 2011-06-08T10:34:42Z

     After compilation I got big list of differences about binaries and 
     other files. You may see it in patch.
    
     Regards,
     Radek
  2. Re: .gitignore for some of cygwin files

    Magnus Hagander <magnus@hagander.net> — 2011-06-09T12:12:59Z

    On Wed, Jun 8, 2011 at 12:34, Radosław Smogura <rsmogura@softperience.eu> wrote:
    > After compilation I got big list of differences about binaries and other
    > files. You may see it in patch.
    
    Hmm. Does this really affect just cygwin, and not also mingw? I know
    msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs go
    there?
    
    What's "nbproject"?
    
    As for the patch itself, we don't normally keep comments in the
    .gitignore files, I'm not sure if we want to start doing that...
    
    
    -- 
     Magnus Hagander
     Me: http://www.hagander.net/
     Work: http://www.redpill-linpro.com/
    
    
  3. Re: .gitignore for some of cygwin files

    Radosław Smogura <rsmogura@softperience.eu> — 2011-06-09T13:36:35Z

     On Thu, 9 Jun 2011 14:12:59 +0200, Magnus Hagander wrote:
    > On Wed, Jun 8, 2011 at 12:34, Radosław Smogura
    > <rsmogura@softperience.eu> wrote:
    >> After compilation I got big list of differences about binaries and 
    >> other
    >> files. You may see it in patch.
    >
    > Hmm. Does this really affect just cygwin, and not also mingw? I know
    > msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs 
    > go
    > there?
    
     Actually I called compilation from make in cygwin env, as I can't run 
     build on Windows7/VisualStudio 2010. I don't know if this is preferred 
     method.
    
     From configure script
    
     checking for ld used by GCC... /usr/i686-pc-cygwin/bin/ld.exe
     checking if the linker (/usr/i686-pc-cygwin/bin/ld.exe) is GNU ld... 
     yes
    
     CC runs as
     GNU C (GCC) version 4.3.4 20090804 (release) 1 (i686-pc-cygwin)
             compiled by GNU C version 4.3.4 20090804 (release) 1, GMP 
     version 4.3.1, MPFR version 2.4.1-p5.
     GGC heuristics: --param ggc-min-expand=100 --param 
     ggc-min-heapsize=131072
    
     After compilation I got many of *dll.def and others.
    
    >
    > What's "nbproject"?
     Just configuration from some editor. It looks like any move in project 
     creates this entry in .gitignore
    
    > As for the patch itself, we don't normally keep comments in the
    > .gitignore files, I'm not sure if we want to start doing that...
     This is not my part - just wanted to comment what and why.
    
     Regards,
     Radek
    
    
  4. Re: .gitignore for some of cygwin files

    Andrew Dunstan <andrew@dunslane.net> — 2011-06-09T13:40:13Z

    
    On 06/09/2011 08:12 AM, Magnus Hagander wrote:
    > On Wed, Jun 8, 2011 at 12:34, Radosław Smogura<rsmogura@softperience.eu>  wrote:
    >> After compilation I got big list of differences about binaries and other
    >> files. You may see it in patch.
    > Hmm. Does this really affect just cygwin, and not also mingw?
    
    Yes, indeed.
    
    > I know
    > msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs go
    > there?
    
    
    The .exe files go exactly where linked executables go on Unix. We could 
    add .gitignore lines for them just as we have for Unix, e.g. by adding 
    "/initdb.exe" to src/bin/initdb.gitignore, or more simply by adding a 
    global rule for "*.exe" as the patch proposes.
    
    cheers
    
    andrew
    
    
    
    
    
  5. Re: .gitignore for some of cygwin files

    Radosław Smogura <rsmogura@softperience.eu> — 2011-06-09T13:40:52Z

     On Thu, 9 Jun 2011 14:12:59 +0200, Magnus Hagander wrote:
    > On Wed, Jun 8, 2011 at 12:34, Radosław Smogura
    > <rsmogura@softperience.eu> wrote:
    >> After compilation I got big list of differences about binaries and 
    >> other
    >> files. You may see it in patch.
    >
    > Hmm. Does this really affect just cygwin, and not also mingw? I know
    > msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs 
    > go
    > there?
    >
    > What's "nbproject"?
    >
    > As for the patch itself, we don't normally keep comments in the
    > .gitignore files, I'm not sure if we want to start doing that...
    
     Sorry for trash this is `git status` after compilation on branch
    
     #       .gitignore-for-cygwin.diff
     #       blob_20110601.patch
     #       nbproject/
     #       src/backend/postgres.def
     #       src/backend/postgres.exe
     #       
     src/backend/replication/libpqwalreceiver/liblibpqwalreceiverdll.def
     #       src/backend/snowball/libdict_snowballdll.def
     #       src/backend/utils/adt/blob.c
     #       
     src/backend/utils/mb/conversion_procs/ascii_and_mic/libascii_and_micdll.def
     #       
     src/backend/utils/mb/conversion_procs/cyrillic_and_mic/libcyrillic_and_micdll.def
     #       
     src/backend/utils/mb/conversion_procs/euc2004_sjis2004/libeuc2004_sjis2004dll.def
     #       
     src/backend/utils/mb/conversion_procs/euc_cn_and_mic/libeuc_cn_and_micdll.def
     #       
     src/backend/utils/mb/conversion_procs/euc_jp_and_sjis/libeuc_jp_and_sjisdll.def
     #       
     src/backend/utils/mb/conversion_procs/euc_kr_and_mic/libeuc_kr_and_micdll.def
     #       
     src/backend/utils/mb/conversion_procs/euc_tw_and_big5/libeuc_tw_and_big5dll.def
     #       
     src/backend/utils/mb/conversion_procs/latin2_and_win1250/liblatin2_and_win1250dll.def
     #       
     src/backend/utils/mb/conversion_procs/latin_and_mic/liblatin_and_micdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_ascii/libutf8_and_asciidll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_big5/libutf8_and_big5dll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_cyrillic/libutf8_and_cyrillicdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_euc2004/libutf8_and_euc2004dll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_euc_cn/libutf8_and_euc_cndll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_euc_jp/libutf8_and_euc_jpdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_euc_kr/libutf8_and_euc_krdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_euc_tw/libutf8_and_euc_twdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_gb18030/libutf8_and_gb18030dll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_gbk/libutf8_and_gbkdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_iso8859/libutf8_and_iso8859dll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_iso8859_1/libutf8_and_iso8859_1dll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_johab/libutf8_and_johabdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_sjis/libutf8_and_sjisdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_sjis2004/libutf8_and_sjis2004dll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_uhc/libutf8_and_uhcdll.def
     #       
     src/backend/utils/mb/conversion_procs/utf8_and_win/libutf8_and_windll.def
     #       src/bin/initdb/initdb.exe
     #       src/bin/pg_basebackup/pg_basebackup.exe
     #       src/bin/pg_config/pg_config.exe
     #       src/bin/pg_controldata/pg_controldata.exe
     #       src/bin/pg_ctl/pg_ctl.exe
     #       src/bin/pg_dump/pg_dump.exe
     #       src/bin/pg_dump/pg_dumpall.exe
     #       src/bin/pg_dump/pg_restore.exe
     #       src/bin/pg_resetxlog/pg_resetxlog.exe
     #       src/bin/psql/psql.exe
     #       src/bin/scripts/clusterdb.exe
     #       src/bin/scripts/createdb.exe
     #       src/bin/scripts/createlang.exe
     #       src/bin/scripts/createuser.exe
     #       src/bin/scripts/dropdb.exe
     #       src/bin/scripts/droplang.exe
     #       src/bin/scripts/dropuser.exe
     #       src/bin/scripts/reindexdb.exe
     #       src/bin/scripts/vacuumdb.exe
     #       src/include/utils/blob.h
     #       src/interfaces/ecpg/preproc/ecpg.exe
     #       src/pl/plpgsql/src/libplpgsqldll.def
     #       src/test/regress/libregressdll.def
     #       src/test/regress/pg_regress.exe
     #       src/timezone/zic.exe
    
    
    
  6. Re: .gitignore for some of cygwin files

    Tom Lane <tgl@sss.pgh.pa.us> — 2011-06-09T13:42:02Z

    =?UTF-8?Q?Rados=C5=82aw_Smogura?= <rsmogura@softperience.eu> writes:
    >  On Thu, 9 Jun 2011 14:12:59 +0200, Magnus Hagander wrote:
    >> What's "nbproject"?
    
    >  Just configuration from some editor. It looks like any move in project 
    >  creates this entry in .gitignore
    
    If you've got random third-party tools that clutter the source tree, you
    should use a personal .gitignore file to ignore them.  We already
    established the principle that emacs backup files have to be ignored on
    a personal level, and I don't see why we'd do it differently for Windows
    tools.
    
    			regards, tom lane
    
    
  7. Re: .gitignore for some of cygwin files

    Magnus Hagander <magnus@hagander.net> — 2011-06-09T14:22:42Z

    On Thu, Jun 9, 2011 at 15:40, Andrew Dunstan <andrew@dunslane.net> wrote:
    >
    >
    > On 06/09/2011 08:12 AM, Magnus Hagander wrote:
    >>
    >> On Wed, Jun 8, 2011 at 12:34, Radosław Smogura<rsmogura@softperience.eu>
    >>  wrote:
    >>>
    >>> After compilation I got big list of differences about binaries and other
    >>> files. You may see it in patch.
    >>
    >> Hmm. Does this really affect just cygwin, and not also mingw?
    >
    > Yes, indeed.
    >
    >> I know
    >> msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs go
    >> there?
    >
    >
    > The .exe files go exactly where linked executables go on Unix. We could add
    > .gitignore lines for them just as we have for Unix, e.g. by adding
    > "/initdb.exe" to src/bin/initdb.gitignore, or more simply by adding a global
    > rule for "*.exe" as the patch proposes.
    
    I think a global exclude for *.exe makes perfect sense. I don't see
    why we would ever want to commit a .exe file to the repository...
    
    -- 
     Magnus Hagander
     Me: http://www.hagander.net/
     Work: http://www.redpill-linpro.com/
    
    
  8. Re: .gitignore for some of cygwin files

    Magnus Hagander <magnus@hagander.net> — 2011-06-09T14:25:07Z

    On Thu, Jun 9, 2011 at 15:40, Radosław Smogura <rsmogura@softperience.eu> wrote:
    > On Thu, 9 Jun 2011 14:12:59 +0200, Magnus Hagander wrote:
    >>
    >> On Wed, Jun 8, 2011 at 12:34, Radosław Smogura
    >> <rsmogura@softperience.eu> wrote:
    >>>
    >>> After compilation I got big list of differences about binaries and other
    >>> files. You may see it in patch.
    >>
    >> Hmm. Does this really affect just cygwin, and not also mingw? I know
    >> msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs go
    >> there?
    >>
    >> What's "nbproject"?
    >>
    >> As for the patch itself, we don't normally keep comments in the
    >> .gitignore files, I'm not sure if we want to start doing that...
    >
    > Sorry for trash this is `git status` after compilation on branch
    >
    > #       .gitignore-for-cygwin.diff
    > #       blob_20110601.patch
    > #       nbproject/
    > #       src/backend/postgres.def
    > #       src/backend/postgres.exe
    > #       src/backend/replication/libpqwalreceiver/liblibpqwalreceiverdll.def
    > #       src/backend/snowball/libdict_snowballdll.def
    > #       src/backend/utils/adt/blob.c
    > #
    > src/backend/utils/mb/conversion_procs/ascii_and_mic/libascii_and_micdll.def
    > #
    > src/backend/utils/mb/conversion_procs/cyrillic_and_mic/libcyrillic_and_micdll.def
    > #
    > src/backend/utils/mb/conversion_procs/euc2004_sjis2004/libeuc2004_sjis2004dll.def
    > #
    > src/backend/utils/mb/conversion_procs/euc_cn_and_mic/libeuc_cn_and_micdll.def
    > #
    > src/backend/utils/mb/conversion_procs/euc_jp_and_sjis/libeuc_jp_and_sjisdll.def
    > #
    > src/backend/utils/mb/conversion_procs/euc_kr_and_mic/libeuc_kr_and_micdll.def
    > #
    > src/backend/utils/mb/conversion_procs/euc_tw_and_big5/libeuc_tw_and_big5dll.def
    > #
    > src/backend/utils/mb/conversion_procs/latin2_and_win1250/liblatin2_and_win1250dll.def
    > #
    > src/backend/utils/mb/conversion_procs/latin_and_mic/liblatin_and_micdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_ascii/libutf8_and_asciidll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_big5/libutf8_and_big5dll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_cyrillic/libutf8_and_cyrillicdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_euc2004/libutf8_and_euc2004dll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_euc_cn/libutf8_and_euc_cndll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_euc_jp/libutf8_and_euc_jpdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_euc_kr/libutf8_and_euc_krdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_euc_tw/libutf8_and_euc_twdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_gb18030/libutf8_and_gb18030dll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_gbk/libutf8_and_gbkdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_iso8859/libutf8_and_iso8859dll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_iso8859_1/libutf8_and_iso8859_1dll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_johab/libutf8_and_johabdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_sjis/libutf8_and_sjisdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_sjis2004/libutf8_and_sjis2004dll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_uhc/libutf8_and_uhcdll.def
    > #
    > src/backend/utils/mb/conversion_procs/utf8_and_win/libutf8_and_windll.def
    > #       src/bin/initdb/initdb.exe
    > #       src/bin/pg_basebackup/pg_basebackup.exe
    > #       src/bin/pg_config/pg_config.exe
    > #       src/bin/pg_controldata/pg_controldata.exe
    > #       src/bin/pg_ctl/pg_ctl.exe
    > #       src/bin/pg_dump/pg_dump.exe
    > #       src/bin/pg_dump/pg_dumpall.exe
    > #       src/bin/pg_dump/pg_restore.exe
    > #       src/bin/pg_resetxlog/pg_resetxlog.exe
    > #       src/bin/psql/psql.exe
    > #       src/bin/scripts/clusterdb.exe
    > #       src/bin/scripts/createdb.exe
    > #       src/bin/scripts/createlang.exe
    > #       src/bin/scripts/createuser.exe
    > #       src/bin/scripts/dropdb.exe
    > #       src/bin/scripts/droplang.exe
    > #       src/bin/scripts/dropuser.exe
    > #       src/bin/scripts/reindexdb.exe
    > #       src/bin/scripts/vacuumdb.exe
    > #       src/include/utils/blob.h
    > #       src/interfaces/ecpg/preproc/ecpg.exe
    > #       src/pl/plpgsql/src/libplpgsqldll.def
    > #       src/test/regress/libregressdll.def
    > #       src/test/regress/pg_regress.exe
    > #       src/timezone/zic.exe
    
    
    Based on this list, a global exclude for "*.exe" and "lib*dll.def"
    seems reasonable. Andrew, does that seem right to you as well? I
    definitely want to keep the nbproject thing out of there, that belongs
    in a personal exclude.
    
    utils/adt/blob.c and include/utils/blob.h - what is that? That's
    something that's actually from your development work and should not be
    ignored, right?
    
    
    -- 
     Magnus Hagander
     Me: http://www.hagander.net/
     Work: http://www.redpill-linpro.com/
    
    
  9. Re: .gitignore for some of cygwin files

    Andrew Dunstan <andrew@dunslane.net> — 2011-06-09T14:40:18Z

    
    On 06/09/2011 10:25 AM, Magnus Hagander wrote:
    >
    > Based on this list, a global exclude for "*.exe" and "lib*dll.def"
    > seems reasonable. Andrew, does that seem right to you as well?
    
    
    That plus an entry in src/backend/.gitignore for "/postgres.def".
    
    cheers
    
    andrew
    
    
    
  10. Re: .gitignore for some of cygwin files

    Radosław Smogura <rsmogura@softperience.eu> — 2011-06-09T15:46:37Z

    Magnus Hagander <magnus@hagander.net> Thursday 09 of June 2011 16:25:07
    > On Thu, Jun 9, 2011 at 15:40, Radosław Smogura <rsmogura@softperience.eu> 
    wrote:
    > > On Thu, 9 Jun 2011 14:12:59 +0200, Magnus Hagander wrote:
    > >> On Wed, Jun 8, 2011 at 12:34, Radosław Smogura
    > >> 
    > >> <rsmogura@softperience.eu> wrote:
    > >>> After compilation I got big list of differences about binaries and
    > >>> other files. You may see it in patch.
    > >> 
    > >> Hmm. Does this really affect just cygwin, and not also mingw? I know
    > >> msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs go
    > >> there?
    > >> 
    > >> What's "nbproject"?
    > >> 
    > >> As for the patch itself, we don't normally keep comments in the
    > >> .gitignore files, I'm not sure if we want to start doing that...
    > > 
    > > Sorry for trash this is `git status` after compilation on branch
    > > 
    > > #       .gitignore-for-cygwin.diff
    > > #       blob_20110601.patch
    > > #       nbproject/
    > > #       src/backend/postgres.def
    > > #       src/backend/postgres.exe
    > > #      
    > > src/backend/replication/libpqwalreceiver/liblibpqwalreceiverdll.def #  
    > >     src/backend/snowball/libdict_snowballdll.def
    > > #       src/backend/utils/adt/blob.c
    > > #
    > > src/backend/utils/mb/conversion_procs/ascii_and_mic/libascii_and_micdll.d
    > > ef #
    > > src/backend/utils/mb/conversion_procs/cyrillic_and_mic/libcyrillic_and_mi
    > > cdll.def #
    > > src/backend/utils/mb/conversion_procs/euc2004_sjis2004/libeuc2004_sjis200
    > > 4dll.def #
    > > src/backend/utils/mb/conversion_procs/euc_cn_and_mic/libeuc_cn_and_micdll
    > > .def #
    > > src/backend/utils/mb/conversion_procs/euc_jp_and_sjis/libeuc_jp_and_sjisd
    > > ll.def #
    > > src/backend/utils/mb/conversion_procs/euc_kr_and_mic/libeuc_kr_and_micdll
    > > .def #
    > > src/backend/utils/mb/conversion_procs/euc_tw_and_big5/libeuc_tw_and_big5d
    > > ll.def #
    > > src/backend/utils/mb/conversion_procs/latin2_and_win1250/liblatin2_and_wi
    > > n1250dll.def #
    > > src/backend/utils/mb/conversion_procs/latin_and_mic/liblatin_and_micdll.d
    > > ef #
    > > src/backend/utils/mb/conversion_procs/utf8_and_ascii/libutf8_and_asciidll
    > > .def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_big5/libutf8_and_big5dll.d
    > > ef #
    > > src/backend/utils/mb/conversion_procs/utf8_and_cyrillic/libutf8_and_cyril
    > > licdll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_euc2004/libutf8_and_euc200
    > > 4dll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_euc_cn/libutf8_and_euc_cnd
    > > ll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_euc_jp/libutf8_and_euc_jpd
    > > ll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_euc_kr/libutf8_and_euc_krd
    > > ll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_euc_tw/libutf8_and_euc_twd
    > > ll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_gb18030/libutf8_and_gb1803
    > > 0dll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_gbk/libutf8_and_gbkdll.def
    > > #
    > > src/backend/utils/mb/conversion_procs/utf8_and_iso8859/libutf8_and_iso885
    > > 9dll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_iso8859_1/libutf8_and_iso8
    > > 859_1dll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_johab/libutf8_and_johabdll
    > > .def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_sjis/libutf8_and_sjisdll.d
    > > ef #
    > > src/backend/utils/mb/conversion_procs/utf8_and_sjis2004/libutf8_and_sjis2
    > > 004dll.def #
    > > src/backend/utils/mb/conversion_procs/utf8_and_uhc/libutf8_and_uhcdll.def
    > > #
    > > src/backend/utils/mb/conversion_procs/utf8_and_win/libutf8_and_windll.def
    > > #       src/bin/initdb/initdb.exe
    > > #       src/bin/pg_basebackup/pg_basebackup.exe
    > > #       src/bin/pg_config/pg_config.exe
    > > #       src/bin/pg_controldata/pg_controldata.exe
    > > #       src/bin/pg_ctl/pg_ctl.exe
    > > #       src/bin/pg_dump/pg_dump.exe
    > > #       src/bin/pg_dump/pg_dumpall.exe
    > > #       src/bin/pg_dump/pg_restore.exe
    > > #       src/bin/pg_resetxlog/pg_resetxlog.exe
    > > #       src/bin/psql/psql.exe
    > > #       src/bin/scripts/clusterdb.exe
    > > #       src/bin/scripts/createdb.exe
    > > #       src/bin/scripts/createlang.exe
    > > #       src/bin/scripts/createuser.exe
    > > #       src/bin/scripts/dropdb.exe
    > > #       src/bin/scripts/droplang.exe
    > > #       src/bin/scripts/dropuser.exe
    > > #       src/bin/scripts/reindexdb.exe
    > > #       src/bin/scripts/vacuumdb.exe
    > > #       src/include/utils/blob.h
    > > #       src/interfaces/ecpg/preproc/ecpg.exe
    > > #       src/pl/plpgsql/src/libplpgsqldll.def
    > > #       src/test/regress/libregressdll.def
    > > #       src/test/regress/pg_regress.exe
    > > #       src/timezone/zic.exe
    > 
    > Based on this list, a global exclude for "*.exe" and "lib*dll.def"
    > seems reasonable. Andrew, does that seem right to you as well? I
    > definitely want to keep the nbproject thing out of there, that belongs
    > in a personal exclude.
    > 
    > utils/adt/blob.c and include/utils/blob.h - what is that? That's
    > something that's actually from your development work and should not be
    > ignored, right?
    
    Thats mine, sorry, looks I didn't get diff directly from master.
    
    Regards,
    Radek
    
    
  11. Re: .gitignore for some of cygwin files

    Magnus Hagander <magnus@hagander.net> — 2011-06-09T16:13:04Z

    On Thu, Jun 9, 2011 at 16:40, Andrew Dunstan <andrew@dunslane.net> wrote:
    >
    >
    > On 06/09/2011 10:25 AM, Magnus Hagander wrote:
    >>
    >> Based on this list, a global exclude for "*.exe" and "lib*dll.def"
    >> seems reasonable. Andrew, does that seem right to you as well?
    >
    >
    > That plus an entry in src/backend/.gitignore for "/postgres.def".
    
    Right. Agreed and committed.
    
    
    -- 
     Magnus Hagander
     Me: http://www.hagander.net/
     Work: http://www.redpill-linpro.com/
    
    
  12. Re: .gitignore for some of cygwin files

    Alvaro Herrera <alvherre@commandprompt.com> — 2011-06-09T16:55:24Z

    Excerpts from Tom Lane's message of jue jun 09 09:42:02 -0400 2011:
    > =?UTF-8?Q?Rados=C5=82aw_Smogura?= <rsmogura@softperience.eu> writes:
    > >  On Thu, 9 Jun 2011 14:12:59 +0200, Magnus Hagander wrote:
    > >> What's "nbproject"?
    > 
    > >  Just configuration from some editor. It looks like any move in project 
    > >  creates this entry in .gitignore
    > 
    > If you've got random third-party tools that clutter the source tree, you
    > should use a personal .gitignore file to ignore them.  We already
    > established the principle that emacs backup files have to be ignored on
    > a personal level, and I don't see why we'd do it differently for Windows
    > tools.
    
    I agree with that, though the *dll.def files are ours and probably
    deserve a global .gitignore entry.
    
    As for executables, I think the local .gitignore files in each subdir
    should be tweaked so that they catch the .exe extension, so
    src/backend/.gitignore which currently includes /postgres should also
    have /postgres.exe, and so on.
    
    -- 
    Álvaro Herrera <alvherre@commandprompt.com>
    The PostgreSQL Company - Command Prompt, Inc.
    PostgreSQL Replication, Consulting, Custom Development, 24x7 support
    
    
  13. Re: .gitignore for some of cygwin files

    Tom Lane <tgl@sss.pgh.pa.us> — 2011-06-09T16:57:46Z

    Alvaro Herrera <alvherre@commandprompt.com> writes:
    > I agree with that, though the *dll.def files are ours and probably
    > deserve a global .gitignore entry.
    
    Agreed, and that's done.
    
    > As for executables, I think the local .gitignore files in each subdir
    > should be tweaked so that they catch the .exe extension, so
    > src/backend/.gitignore which currently includes /postgres should also
    > have /postgres.exe, and so on.
    
    I agree with the committed patch, which just added one global *.exe
    pattern.  I don't see the value of having to maintain a second
    .gitignore entry in every subdirectory that builds an executable.
    
    			regards, tom lane
    
    
  14. Re: .gitignore for some of cygwin files

    Alvaro Herrera <alvherre@commandprompt.com> — 2011-06-09T17:09:39Z

    Excerpts from Tom Lane's message of jue jun 09 12:57:46 -0400 2011:
    > Alvaro Herrera <alvherre@commandprompt.com> writes:
    > > I agree with that, though the *dll.def files are ours and probably
    > > deserve a global .gitignore entry.
    > 
    > Agreed, and that's done.
    
    Oh, I see ... I haven't gotten the commit message yet.
    
    -- 
    Álvaro Herrera <alvherre@commandprompt.com>
    The PostgreSQL Company - Command Prompt, Inc.
    PostgreSQL Replication, Consulting, Custom Development, 24x7 support
    
    
  15. Re: .gitignore for some of cygwin files

    Peter Eisentraut <peter_e@gmx.net> — 2011-06-16T10:36:14Z

    On tor, 2011-06-09 at 16:25 +0200, Magnus Hagander wrote:
    > Based on this list, a global exclude for "*.exe" and "lib*dll.def"
    > seems reasonable.
    
    We already have finer-grained excludes for various lib*dll.def
    variations in the libpq and ecpg subdirectories.  Those should be
    cleaned up if we are adding a global one.
    
    
    
    
  16. Re: .gitignore for some of cygwin files

    Magnus Hagander <magnus@hagander.net> — 2011-06-18T16:29:07Z

    On Thu, Jun 16, 2011 at 12:36, Peter Eisentraut <peter_e@gmx.net> wrote:
    > On tor, 2011-06-09 at 16:25 +0200, Magnus Hagander wrote:
    >> Based on this list, a global exclude for "*.exe" and "lib*dll.def"
    >> seems reasonable.
    >
    > We already have finer-grained excludes for various lib*dll.def
    > variations in the libpq and ecpg subdirectories.  Those should be
    > cleaned up if we are adding a global one.
    
    There's no "if", since we already added the global one.
    
    So - I've removed the local ones.
    
    -- 
     Magnus Hagander
     Me: http://www.hagander.net/
     Work: http://www.redpill-linpro.com/