Horton

Re: doc: modify the comment in function libpqrcv_check_conninfo()

Rintaro Ikeda <ikedarintarof@oss.nttdata.com>

View thread View on postgr.es
From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: pgsql-hackers@postgresql.org
Date: 2024-06-27T07:09:37Z
Lists: pgsql-hackers

Attachments

Thank you for your comment!

I've added the must_use_password argument. A new patch is attached.


On 2024-06-26 23:36, Jelte Fennema-Nio wrote:
> On Wed, 26 Jun 2024 at 14:53, ikedarintarof
> <ikedarintarof@oss.nttdata.com> wrote:
>> The function 'libpqrcv_check_conninfo()' returns 'void', but the 
>> comment
>> above says that the function returns true or false.
>> I've attached a patch to modify the comment.
> 
> Agreed that the current comment is wrong, but the new comment should
> mention the must_use_password argument. Because only if
> must_use_password is true, will it throw an error.

Commits

  1. Fix comment in libpqrcv_check_conninfo().