Re: pgsql: Add function to import operating system collations
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Date: 2017-01-18T17:23:24Z
Lists: pgsql-hackers
On 1/18/17 10:43 AM, Tom Lane wrote: > Maybe an appropriate fix would be to ignore collations whose names aren't > equal to what we get for collcollate/collctype. Presumably the latter > are getting canonicalized somehow. Yeah, it's supposed to do that. Note that the second call to CollationCreate() in pg_import_system_collations() has the "if not exists" argument true regardless. So the error appears to come from the first one. What's fishy about this is that I can't reproduce it locally in a variety of VMs, and the buildfarm is not unanimous either. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Avoid conflicts with collation aliases generated by stripping.
- 0333a7340054 10.0 landed
-
Add function to import operating system collations
- aa17c06fb585 10.0 cited
-
Remove dead code in bootstrap
- 193a7d791ebe 10.0 cited