Re: Fix pg_stat_reset_single_table_counters function
Masahiro Ikeda <ikedamsh@oss.nttdata.com>
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Andres Freund
<andres@anarazel.de>, pgsql-hackers@lists.postgresql.org,
mitsuru.hinata.5432@gmail.com
Date: 2023-08-21T04:32:24Z
Lists: pgsql-hackers
Attachments
- v5-0001-Fix-pg_stat_reset_single_table_counters-function.patch (text/x-diff) patch v5-0001
On 2023-08-21 11:33, Kyotaro Horiguchi wrote: > On 2023/08/15 14:13, Masahiro Ikeda wrote: >> On 2023-08-15 11:48, Masahiko Sawada wrote: >>> +COMMENT ON DATABASE :current_database IS 'This is a test comment'; >>> -- insert or update in 'pg_shdescription' >>> >>> I think the current_database should be quoted (see other examples >>> where using current_database(), e.g. collate.linux.utf8.sql). Also it >>> would be better to reset the comment after the test. >> > > I'm not sure about others, but I would avoid using the name > "current_database" for the variable. > > I would just use "database" or "db" instead. Thanks! I agree your comment. I fixed in v5 patch. Regards, -- Masahiro Ikeda NTT DATA CORPORATION
Commits
-
Fix pg_stat_reset_single_table_counters() for shared relations
- ad8753a3a717 15.5 landed
- d6af45052dc8 16.0 landed
- 6fde2d9a005a 17.0 landed