Horton

Re: stats_ext test fails with -DCATCACHE_FORCE_RELEASE

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-05-02T01:40:11Z
Lists: pgsql-hackers 
On 2018/05/02 0:33, Tom Lane wrote:
> Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
>> While playing around with a -DCATCACHE_FORCE_RELEASE build, I noticed that
>> stats_ext test failed with errors for multiple statements that looked like
>> this:
>> ERROR:  invalid ndistinct magic 7f7f7f7f (expected a352bfa4)
> 
> Interesting.  How come the buildfarm hasn't noticed this?  I should
> think that the CLOBBER_CACHE_ALWAYS animals, as well as the one(s)
> using -DCATCACHE_FORCE_RELEASE, would have shown failures.

I too wondered why.  Fwiw, similar failure occurs in PG 10 branch.

Thanks,
Amit

Commits

  1. Fix bogus code for extracting extended-statistics data from syscache.