Horton

Re: daitch_mokotoff module

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Dag Lem <dag@nimrod.no>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Paul Ramsey <pramsey@cleverelephant.ca>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-08T11:50:00Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid using non-ASCII commentary in daitch_mokotoff.c.

  2. Remove some non-ASCII symbols from a comment.

  3. Remove useless dependencies in daitch_mokotoff_header.pl.

  4. Pacify perlcritic.

  5. Add support for Daitch-Mokotoff Soundex in contrib/fuzzystrmatch.

  6. Enable routine running of citext's UTF8-specific test cases.

On 2023-04-07 Fr 23:25, Tom Lane wrote:
> I wrote:
>> Anyway, I assume this is just syntactic sugar for something
>> we can do another way?  If it's at all fundamental, I'll have
>> to back the patch out.
> On closer inspection, this script is completely devoid of any
> need to deal in non-ASCII data at all.  So I just nuked the
> "use" lines.
>
> 			


Yeah.

I just spent a little while staring at the perl code. I have to say it 
seems rather opaque, the data structure seems a bit baroque. I'll try to 
simplify it.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com