Re: Windows: openssl & gssapi dislike each other

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Andres Freund <andres@anarazel.de>

Cc: Andrew Dunstan <andrew@dunslane.net>, Dave Page <dpage@pgadmin.org>, Imran Zaheer <imran.zhir@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>

Date: 2025-01-31T15:34:51Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Move GSSAPI includes into its own header
- e92c0632c147 18.0 landed
Tighten test_predtest's input checks, and improve error messages.
- 00ac25a3c365 17.0 cited
Collation documentation fixes.
- 8ba34c698d19 17.0 cited
contrib/sslinfo needs a fix too to make hamerkop happy.
- 568620dfd691 15.0 cited
Second attempt to silence SSL compile failures on hamerkop.
- 1241fcbd7e64 15.0 cited

> On 31 Jan 2025, at 16:29, Andres Freund <andres@anarazel.de> wrote:

>> #ifdef ENABLE_GSS
>> -#if defined(HAVE_GSSAPI_H)
>> -#include <gssapi.h>
>> -#else
>> -#include <gssapi/gssapi.h>
>> -#endif /* HAVE_GSSAPI_H */
>> +#include "libpq/pg-gssapi.h"
>> #endif /* ENABLE_GSS */
> 
> This #ifdef ENABLE_GSS probably isn't necessary anymore.

Yeah, I only left it for code documentation reasons to keep readers from
thinking the ifdef was missing and had to go chase it in the new file.  It's
definitely not required though I for sure don't mind removing it if others feel
it's pointless.

--
Daniel Gustafsson