Re: BUG #18224: message bug in libpqwalreceiver.c.
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: king tomo <t.katsumata1122@gmail.com>,
pgsql-bugs@lists.postgresql.org
Date: 2023-12-05T13:44:20Z
Lists: pgsql-bugs
> On 4 Dec 2023, at 15:18, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <daniel@yesql.se> writes: >> How about fixing the error message in the backbranches, with a comment why we >> expect 3 and not 4 fields, and requiring 4 thus restricting to 9.4+ in HEAD? > > OK by me. Following the bouncing ball it turns out that restricting to 9.4+ (effectively reapplying 083d29c65b78 adapted to the callsites moved to a common function) across the board isn't doable since pg_basebackup requires IDENTIFY_SYSTEM for 9.1->9.3 to get the starttli. Thus I opted for just fixing the error message and left the restriction on 9.4+ as future work for when it can be done across all callers. -- Daniel Gustafsson
Commits
-
Fix typo in comment
- d86038bd4d81 14.11 landed
- c5962ad21a6e 17.0 landed
- 810c9609f8a5 16.2 landed
- 5902ba5b21da 12.18 landed
- 419b6cb885a5 15.6 landed
- 00b222226f81 13.14 landed