Re: nodes/*funcs.c inconsistencies

Kouhei Kaigai <kaigai@ak.jp.nec.com>

From: Kouhei Kaigai <kaigai@ak.jp.nec.com>

To: Noah Misch <noah@leadboat.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Cc: "robertmhaas@gmail.com" <robertmhaas@gmail.com>, "sfrost@snowman.net" <sfrost@snowman.net>

Date: 2015-08-03T01:32:10Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add support for renaming domain constraints
- 38b9693fd984 9.2.0 cited

> On Mon, Apr 16, 2012 at 06:25:15AM -0400, Noah Misch wrote:
> > I observed these inconsistencies in node support functions:
> 
> A fresh audit found the attached problems new in 9.5[1].  Most are cosmetic
> INT/UINT or field order corrections.  The non-cosmetic changes involve
> CustomPath, CustomScan, and CreatePolicyStmt.  Feature committers, if the
> existing treatments (ignore custom_plans/custom_paths fields; copy/compare
> "cmd" string pointer as a scalar) were deliberate, please let me know.
>
Thanks for your works.

I also noticed one other inconsistent point; _outMergeJoin() dumps
mergeNullsFirst[] array but it does not use booltostr() macro.

Best regards,
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai@ak.jp.nec.com>