Horton

Re: pgsql: Provide overflow safe integer math inline functions.

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org,Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org,Michael Paquier <michael.paquier@gmail.com>
Date: 2017-12-17T01:35:05Z
Lists: pgsql-hackers 

On December 16, 2017 5:31:01 PM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Andres Freund <andres@anarazel.de> writes:
>> I'm not quite following. Could you check if the same happens without
>> -O2? Not because that'd be a solution, but to narrow down how this
>> happens?
>
>The committed test looks quite broken to me: it's missing some &
>operators.  Not sure how that translates into failing to fail the
>configure test,

Hm, true. As you say, it doesn't explain the problem though, it's just weird int  to ptr cases. Kinda seems like clang links to a different runtime during the configure tests than what's used for postgres...

Andres

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Commits

  1. Try harder to detect unavailability of __builtin_mul_overflow(int64).

  2. Try to detect runtime unavailability of __builtin_mul_overflow(int64).

  3. Fix a number of copy & paste comment errors in common/int.h.

  4. Provide overflow safe integer math inline functions.