Horton

Re: [BUG] Logical replica crash if there was an error in a function.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Anton A. Melnikov" <aamelnikov@inbox.ru>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Maxim Orlov <orlovmg@gmail.com>
Date: 2022-11-15T01:59:42Z
Lists: pgsql-hackers 
"Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
> On 02.11.2022 21:02, Tom Lane wrote:
>> I don't think the cost of that test case is justified by the tiny
>> probability that it'd ever catch anything.

> Seems it is possible to do a test without these remarks. The attached
> test uses existing nodes and checks the specific error message.

My opinion remains unchanged: this would be a very poor use of test
cycles.

> Additionally
> i've tried to reduce overall number of nodes previously
> used in this test in a similar way.

Optimizing existing tests isn't an answer to that.  We could
install those optimizations without adding a new test case.

			regards, tom lane

Commits

  1. Avoid crash after function syntax error in a replication worker.