Thread

Re: pg_dump: Remove trivial usage of PQExpBuffer

Daniel Gustafsson <daniel@yesql.se> — 2025-12-16T22:44:28Z

> On 16 Dec 2025, at 23:03, Corey Huinker <corey.huinker@gmail.com> wrote:

> One thing I have noticed is the usage of PQExpBuffer in situations where the query has no optional parts and no string interpolation.

-	res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);
+	res = ExecuteSqlQuery(fout,
+						  "SELECT DISTINCT attrelid FROM pg_attribute "
+						  "WHERE attacl IS NOT NULL",
+						  PGRES_TUPLES_OK);

I'm not sure I find it an improvement to put have to look after the query text
(which can be long) for the ExecStatusType.  Having it separated from the query
is more readable IMHO (I know we have a mix of both already, but I kind of
prefer passing in the buffer).

--
Daniel Gustafsson