Re: pgsql: Move SQL-callable code related to multixacts into its own file
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>, pgsql-committers@lists.postgresql.org
Date: 2025-08-20T12:17:26Z
Lists: pgsql-hackers
Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes: > On Tue, Aug 19, 2025 at 11:27:25AM -0400, Tom Lane wrote: >> I think "make world-bin" >> or "make install-world" are the accepted targets for building everything. > From what I can see, only: > check-world: > checkprep: > installcheck-world: > build src/test/modules. I agree that this does not meet the principle of least surprise. world-bin ought to build every bit of C code we have. > I just found surprising that a "default" make (no target specified) does not > build src/test/modules while a "default" meson/ninja does. In itself that observation doesn't bother me: I don't think the conventions in the Meson world are identical to those for makefiles. We've long expected that contrib is not included in the default make target, and it makes sense to me for src/test/modules to work like contrib for this purpose. regards, tom lane
Commits
-
Avoid including commands/dbcommands.h in so many places
- 325fc0ab14d1 19 (unreleased) landed
-
Remove unneeded header declarations in multixact.c
- 24e71d53f88e 19 (unreleased) landed
-
Move SQL-callable code related to multixacts into its own file
- df9133fa6384 19 (unreleased) cited
-
Create a syscache for pg_database-indexed-by-oid, and make use of it
- cb98e6fb8fd4 8.2.0 cited