Horton

Re: Higher level questions around shared memory stats

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>
Date: 2022-03-30T19:44:20Z
Lists: pgsql-hackers 
On 29.03.22 23:01, Andres Freund wrote:
>> I think what's actually most important here is the error reporting. We need
>> to make it clear, at least via log messages, that something bad has
>> happened.
> The message currently (on HEAD, but similarly on the path) is:
> 				ereport(pgStatRunningInCollector ? LOG : WARNING,
> 						(errmsg("corrupted statistics file \"%s\"",
> 								statfile)));

Corrupted how?  How does it know?  Is there a checksum, was the file the 
wrong length, what happened?  I think this could use more detail.

Commits

  1. pgstat: remove stats_temp_directory.

  2. pgstat: consistent function comment formatting.