Horton

Re: Add two missing tests in 035_standby_logical_decoding.pl

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-26T11:13:59Z
Lists: pgsql-hackers 
Hi,

On 4/26/23 11:12 AM, vignesh C wrote:
> On Wed, 26 Apr 2023 at 13:45, Drouvot, Bertrand
> 
> There was one typo in the commit message, subscribtion should be
> subscription, the rest of the changes looks good to me:
> Subject: [PATCH v5] Add subscribtion to the standby test in
>   035_standby_logical_decoding.pl
> 
> Adding one test, to verify that subscribtion to the standby is possible.
> 

Oops, at least I repeated it twice ;-)
Fixed in V6 that I just shared up-thread.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix the race condition in the test case added by commit a6e04b1d20.

  2. Test that invalidated logical slots doesn't retain WAL.

  3. Add a test to verify that subscription to the standby works.

  4. Reduce the log level in 035_standby_logical_decoding.pl.