Horton

Re: Fix tuple deformation with virtual generated NOT NULL columns

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-17T06:11:01Z
Lists: pgsql-hackers 
David Rowley <dgrowleyml@gmail.com> writes:
>> 2. I can't quite figure out the pattern in these tests for dropping vs
>> not dropping the tables at the end of the test. Many tests do DROP
>> TABLE and a large number of others don't bother. What's meant to be
>> happening here?

> I added the DROP TABLE too, as I didn't see any reason mentioned
> anywhere that they should be kept.

A very rough rule of thumb is that we leave tables around if they
might be interesting for the pg_upgrade tests (which try to upgrade
the ending state of the core regression tests).

			regards, tom lane

Commits

  1. Update JIT tuple deforming code for virtual generated columns

  2. Add tuple deformation test for virtual generated columns

  3. Fix tuple deforming with virtual generated columns