Re: Typmod associated with multi-row VALUES constructs
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
david.g.johnston@gmail.com, pgsql-hackers@postgresql.org
Date: 2016-12-08T02:19:01Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > Tom Lane wrote: >> In HEAD, we could change the RTE data structure so that >> transformValuesClause could save the typmod information in the RTE, >> keeping the lookups cheap. > Hmm, I think this would be useful for the XMLTABLE patch too. I talked > a bit about it at > https://www.postgresql.org/message-id/20161122204730.dgipy6gxi25j4e6a@alvherre.pgsql I dunno. If your example there is correct that XMLTABLE can be called as a plain function in a SELECT list, then I doubt that we want to tie anything about it to the RTE data structure. If anything, the case where it appears in FROM seems to need to be treated as a generic RTE_FUNCTION case. I've been trying to avoid getting involved in the XMLTABLE patch, mainly because I know zip about XML, but maybe I need to take a look. regards, tom lane
Commits
-
Fix reporting of column typmods for multi-row VALUES constructs.
- cf22c8cb8900 9.6.2 landed
- c7a62135acfb 9.4.11 landed
- 6a493adda745 9.5.6 landed
- 2afe282a3732 9.3.16 landed
- 082d1fb9e4ec 9.2.20 landed
- 0b78106cd465 10.0 landed